Add test coverage for top level data key merging #2681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
simonbaird
commented
Aug 7, 2025
| successes: null | ||
| violations: [] | ||
| warnings: | ||
| - msg: '{"george":"lead","john":"rhythm","paul":"bass","ringo":"drums"}' |
Member
Author
There was a problem hiding this comment.
This is the important part. Notice how we get the merged data.
simonbaird
commented
Aug 7, 2025
| --- | ||
|
|
||
| [multiple data source top level key clash:stderr - 1] | ||
| Error: error validating file input.json: evaluating policy: load: load documents: 1 error occurred during loading: ${TEMP}/ec-work-${RANDOM}/dat${RANDOM}/${RANDOM}/data.yaml: merge error |
Member
Author
|
IIUC the tekton lint failure is one we usually ignore. Actually I created #2682 to squelch it. |
st3penta
approved these changes
Aug 8, 2025
simonbaird
force-pushed
the
rego-data-merge-tests
branch
from
bbdebd7 to
1d1b378
Compare
Member
Author
|
Rebased to remove tekton lint fails. |
The motivation is to make sure PR conforma#2656 doesn't change this behavior and potentially break things. The two things being verified: - If the value of the top level key is a map, then the map keys from each data source get merged - If the value of the top level key is not a map, then we fail hard with an error. Ref: https://issues.redhat.com/browse/EC-1418
Should fix a go mod tidy lint error.
simonbaird
force-pushed
the
rego-data-merge-tests
branch
from
1d1b378 to
2e98f3e
Compare
Member
Author
|
Fixed two more lint errors, one about the license preamble, and one go mod tidy. Hopefully good now, will set it to automerge and 🤞 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is to make sure PR #2656 doesn't change this behavior and potentially break things.
The two things being verified:
Ref: https://issues.redhat.com/browse/EC-1418